[PATCH] debug: Add minimalist D_* macros

Christof Schmitt cs at samba.org
Mon Dec 5 17:32:22 UTC 2016

On Mon, Dec 05, 2016 at 12:06:08PM +1100, Amitay Isaacs wrote:
> On Thu, Dec 1, 2016 at 3:57 PM, Martin Schwenke <martin at meltin.net> wrote:
> > These don't include the function name or any other header.
> >
> > Please review and maybe push...
> >
> > peace & happiness,
> > martin
> >
> Since no one has NACKed it, pushed to autobuild. :-)

I am probably late to this, but could you explain the intended use a bit?

My thoughts: In the past the preference was to always include the
function name in each message, that was the reason for adding it to the
DBG_* macros. Is the preference now (for ctdb?) to not have the function
names in each message?

My preference would be to have one set of entry points into the debug
code, and use those consistently through Samba. If we want to support
both styles (with and without function name prefix), then this could
become a config option for debug.c or it could be hardcoded for each


More information about the samba-technical mailing list