[PATCH] s3: libsmb: Setting the LIBSMBCLIENT_NO_CCACHE environment variable doesn't turn off credential cache use.

[Jeremy Allison]

On Wed, Nov 30, 2016 at 01:41:38PM -0500, Ira Cooper wrote:
> "I absolve you."
> 
> Reviewed-by: Ira Cooper <ira at samba.org>

Hmmm. This patch breaks one of the ccache tests,
let me see if it's the patch or test that's
wrong.

> On Wed, Nov 30, 2016 at 1:27 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Tue, Nov 29, 2016 at 08:22:57PM -0500, Ira Cooper wrote:
> >> Shouldn't it be if the environment var is set?
> >>
> >>      if (getenv("LIBSMBCLIENT_NO_CCACHE") == NULL) {
> >> -        smbc_setOptionUseCCache(context, true);
> >> +        smbc_setOptionUseCCache(context, false);
> >>      }
> >>
> >> Shouldn't it be !=?
> >>
> >> Cheers,
> >
> > Fixed patch attached. Sorry for the screw-up :-(.
> > (even one-liners can be messed up :-).
> >
> > Thanks,
> >
> > Jeremy.