[PATCH] trivial cleanups
Jeremy Allison
jra at samba.org
Wed Aug 31 19:17:47 UTC 2016
On Wed, Aug 31, 2016 at 04:15:05PM +0200, Volker Lendecke wrote:
> Hi!
>
> Review appreciated!
LGTM (with missing 'Signed-off-by:' added in patch #1.
Will push on next autobuild.
> From 2441fba42931f8b3cdb04fc8a4727fcb95b12b68 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Wed, 31 Aug 2016 15:38:11 +0200
> Subject: [PATCH 1/2] ldb: Fix a signed/unsigned hickup
>
> ---
> lib/ldb/ldb_map/ldb_map_outbound.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ldb/ldb_map/ldb_map_outbound.c b/lib/ldb/ldb_map/ldb_map_outbound.c
> index e755b7e..fd25c36 100644
> --- a/lib/ldb/ldb_map/ldb_map_outbound.c
> +++ b/lib/ldb/ldb_map/ldb_map_outbound.c
> @@ -190,7 +190,7 @@ static int map_attrs_partition(struct ldb_module *module, void *mem_ctx, const c
> static int ldb_msg_replace(struct ldb_message *msg, const struct ldb_message_element *el)
> {
> struct ldb_message_element *old;
> - int j;
> + unsigned j;
> old = ldb_msg_find_element(msg, el->name);
>
> /* no local result, add as new element */
> --
> 2.1.4
>
>
> From 793c98bc6c6c713cb42c22bd27251b3015e78263 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Wed, 31 Aug 2016 16:12:33 +0200
> Subject: [PATCH 2/2] tevent: Fix some typos
>
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
> lib/tevent/tevent.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/tevent/tevent.h b/lib/tevent/tevent.h
> index 2432344..64e2d98 100644
> --- a/lib/tevent/tevent.h
> +++ b/lib/tevent/tevent.h
> @@ -1393,16 +1393,16 @@ int tevent_timeval_compare(const struct timeval *tv1,
> const struct timeval *tv2);
>
> /**
> - * @brief Get a zero timval value.
> + * @brief Get a zero timeval value.
> *
> - * @return A zero timval value.
> + * @return A zero timeval value.
> */
> struct timeval tevent_timeval_zero(void);
>
> /**
> * @brief Get a timeval value for the current time.
> *
> - * @return A timval value with the current time.
> + * @return A timeval value with the current time.
> */
> struct timeval tevent_timeval_current(void);
>
> --
> 2.1.4
>
More information about the samba-technical
mailing list