[PATCH] Add vectorized tdb_storev

Ralph Böhme slow at samba.org
Mon Aug 29 16:11:14 UTC 2016


On Mon, Aug 29, 2016 at 03:56:03PM +0200, Volker Lendecke wrote:
> Hi!
> 
> Attached find a patchset that implements a writev-style tdb_store. In
> many places in Samba we assemble a tdb record from multiple pieces,
> and without tdb_storev this always involves a malloc and memcpy calls.
> This can be used in a lot more places in Samba, ctdb_ltdb_store() being
> a very obvious candidate (Amitay, hint, hint :-). I've just fixed two
> calls that I've seen in profiles.
> 
> That has just survived the tdb piece of autobuild, still waiting for the
> full one. It has successfully survived an autobuild as part of a larger
> patchset a few days ago.
> 
> Review appreciated!

processing...

Cheerio!
-slow



More information about the samba-technical mailing list