[PATCH] Use krb5_wrap function in gensec_krb5

Andrew Bartlett abartlet at samba.org
Mon Aug 29 09:23:07 UTC 2016

On Tue, 2016-08-16 at 16:53 +0200, Andreas Schneider wrote:
> Hello,
> I have a patchset which mostly converts gensec_krb5 to use not
> implementation 
> specific code but what we have in krb5_wrap. I've already completely
> convert 
> gensec_krb5 to MIT Kerberos but it doesn't work yet. I need to see
> what is 
> going wrong. However with the patchset attached it still works with
> Heimdal.
> I've run some tests to verify it works:
>   samba4.rpc.lsa.secrets (uses fake_gssapi_krb5)
>   samba4.blackbox.passwords (tests kpasswd server which uses
> gensec_krb5)
> Please review carefully!

Have you run tests against Windows?

That is the only thing I would need beyond the re-read I've done to
give a review.  (I have to ask because these things are really easy to
break symmetrically).


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list