[cifs-utils PATCHv2 4/6] cifs.upcall: remove KRB5_TC_OPENCLOSE

Jeff Layton jlayton at samba.org
Thu Aug 25 14:17:43 UTC 2016


The header file says that this is deprecated, and all of the info I've
seen about it mentioned that it was for performance more than
correctness. It dates back to the original code dump from Igor, so I
think we're safe to just drop it at this point.

Signed-off-by: Jeff Layton <jlayton at samba.org>
---
 cifs.upcall.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/cifs.upcall.c b/cifs.upcall.c
index 8448d00f6061..a25833592440 100644
--- a/cifs.upcall.c
+++ b/cifs.upcall.c
@@ -157,9 +157,6 @@ err_endseq:
 err_ccstart:
 	krb5_free_principal(context, principal);
 err_princ:
-#if defined(KRB5_TC_OPENCLOSE)
-	krb5_cc_set_flags(context, ccache, KRB5_TC_OPENCLOSE);
-#endif
 	krb5_cc_close(context, ccache);
 err_cache:
 	return credtime;
@@ -388,9 +385,6 @@ out_free_creds:
 out_free_principal:
 	krb5_free_principal(context, in_creds.client);
 out_free_ccache:
-#if defined(KRB5_TC_OPENCLOSE)
-	krb5_cc_set_flags(context, ccache, KRB5_TC_OPENCLOSE);
-#endif
 	krb5_cc_close(context, ccache);
 	return ret;
 }
-- 
2.7.4




More information about the samba-technical mailing list