SMB1 shadow_copy2 snapshot folder access bug (Was: [PATCH] smbd: Fix snapshot query on shares with DFS enabled)

[Uri Simchoni]

On 08/24/2016 01:32 AM, Jeremy Allison wrote:
> On Tue, Aug 23, 2016 at 02:45:21PM +0300, Uri Simchoni wrote:
>> On 08/22/2016 07:50 PM, Jeremy Allison wrote:
>>>
>>>> Otherwise RB+ me.
>>>
>>> Thanks !
>>>
>>
>> Jeremy,
>>
>> Now that we have full client shadow-copy functionality in place, I am
>> extending our test suite to:
>> - Test both SMB1 and SMB3 (was just SMB1 up to now)
>> - Test ability to read snapshot files and list directories (was mostly
>> testing ability to stat snapshot files)
>>
>> However, as things stand, the directory listing test fails for SMB1
>> (passes SMB3), so this cannot be pushed yet. I'll look at it later, but
>> am attaching this in case you want to have a look yourself (and also to
>> notify that I'm implementing the tests :))
> 
> Thanks, I'm out of the office today, so away from my test env,
> but I'll take a look tomorrow.
> 
This is actually a bug (opened
https://bugzilla.samba.org/show_bug.cgi?id=12172), probably a regression
introduced some months ago by (my) fix to bug 11580. Only occurs if the
client uses SMB1. I think I have a simple fix in vfs_shadow_copy2, but I
have to think it over. I may get back to it only in a couple of days though.

Thanks,
Uri.