[PATCH] Improve ldb unindexed search perf

Andreas Schneider asn at samba.org
Tue Aug 23 06:15:40 UTC 2016

On Tuesday, 23 August 2016 17:28:45 CEST Andrew Bartlett wrote:
> This patch set helps us to avoid many talloc() and talloc_free() calls
> during the scan of the whole database or of a large index.
> Please review.

I've did a quick look an this looks great. However for compare functions could 
you please do:

int cmp;

cmp = ldb_attr_cmp();
if (cmp == 0) {

in patch #2 and the same for strcmp() in patch #3.

I would prefer to have:

if (el2->name == NULL) {
    goto failed;

instead of

if (el2->name == NULL) goto failed;

We use brackets for a reason ;)


	-- andreas

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list