[PATCHES] limit kerberos encryption types used by winbindd

[Andrew Bartlett]

On Tue, 2016-08-23 at 07:59 +0300, Uri Simchoni wrote:
> Hi Garming,
> 
> Sorry about that - my intention was to pass those tests if tshark is
> not
> installed but apparently I haven't really tested this case.
> 
> It turns out a test needs to emit success messages for subunit to
> declare it as passed, not just return 0.
> 
> I hope the attached fixes it - please review and push if happy.

Can you make it issue skip instead?

eg this from dbcheck-oldrelease.sh:

  subunit_start_test "ldapcmp"
    subunit_skip_test "ldapcmp" <<EOF
no test provision
EOF

> Thanks,
> Uri.
> 
> On 08/23/2016 07:02 AM, Garming Sam wrote:
> > Hi Uri,
> > 
> > I've been getting errors on this test, where my system doesn't have
> > tshark installed.
> > 
> > [1(0)/3 at 0s] samba4.blackbox.client_etypes_all(ad_dc:client)
> > command:
> > /home/garming/wintest/testprogs/blackbox/test_client_etypes.sh
> > $DC_SERVER $DC_USERNAME $DC_PASSWORD $PREFIX_ABS all 17_18_23
> > 2>&1  |
> > /home/garming/wintest/selftest/filter-subunit --fail-on-empty
> > --prefix="samba4.blackbox.client_etypes_all(ad_dc:client)."
> > --suffix="(ad_dc:client)"
> > expanded command:
> > /home/garming/wintest/testprogs/blackbox/test_client_etypes.sh addc
> > Administrator locDCpass1 /home/garming/wintest/st all 17_18_23
> > 2>&1  |
> > /home/garming/wintest/selftest/filter-subunit --fail-on-empty
> > --prefix="samba4.blackbox.client_etypes_all(ad_dc:client)."
> > --suffix="(ad_dc:client)"
> > ERROR: Testsuite[samba4.blackbox.client_etypes_all(ad_dc:client)]
> > REASON: Exit code was 1
> > 
> > 
> > I was wondering if you could look into it?
> > 
> > 
> > Cheers,
> > 
> > Garming
> > 
> > On 07/08/16 05:20, Uri Simchoni wrote:
> > > On 08/04/2016 09:52 PM, Jeremy Allison wrote:
> > > > Uri - In trying to push this I'm getting:
> > > > 
> > > > [1616(10428)/1954 at 1h52m16s]
> > > > samba4.blackbox.client_etypes_all(ad_dc:client)
> > > > UNEXPECTED(failure):
> > > > samba4.blackbox.client_etypes_all(ad_dc:client).verify
> > > > types(ad_dc:client)
> > > > REASON: Exception: Exception:
> > > > 
> > > > FAILED (1 failures, 0 errors and 0 unexpected successes in 0
> > > > testsuites)
> > > > 
> > > > which does seem related even with the latest autobuild mess.
> > > > 
> > > > Can you investigate please ?
> > > > 
> > > > Cheers,
> > > > 
> > > > 	Jeremy.
> > > > 
> > > Older version of tshark. The wireshark Kerberos dissector was
> > > replaced
> > > in commit dea68bf0.
> > > 
> > > I hope those are the only two versions of wireshark Kerberos
> > > dissector
> > > in use and that the dissector output will be stable enough...
> > > 
> > > The attached patch set only modifies the tshark line in the test.
> > > Passes
> > > autobuild-private.sh on sn-devel and locally on my machine.
> > > 
> > > Thanks,
> > > Uri.
> > 
> > 
> 
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba