[PATCH] Fix format-nonliteral warnings

Amitay Isaacs amitay at gmail.com
Sun Aug 21 17:19:34 UTC 2016


On Sun, Aug 21, 2016 at 2:49 AM, Amitay Isaacs <amitay at gmail.com> wrote:

>
> On Fri, Aug 19, 2016 at 7:30 PM, Andreas Schneider <asn at samba.org> wrote:
>
>> On Friday, 19 August 2016 18:54:03 CEST Amitay Isaacs wrote:
>> > On Fri, Aug 19, 2016 at 4:28 PM, Andreas Schneider <asn at samba.org>
>> wrote:
>> > > On Friday, 19 August 2016 01:40:13 CEST Amitay Isaacs wrote:
>> > > > Hi,
>> > > >
>> > > > Here are few fixes which add decorations to functions that use
>> printf
>> > > > format strings.
>> > > > These helped catch missing arguments or missing format elements
>> errors.
>> > > >
>> > > > They are strictly not bug fixes.  So do we want to backport them to
>> 4.5?
>> > > >
>> > > > Please review and push.
>> > >
>> > > RB+ but you should file a bug and add the BUG: url line to all the
>> patches
>> > > so
>> > > we can backport to at least 4.5.
>> >
>> > Done.
>> >
>> > Here are the patches with your RB.
>>
>> LGTM. Please push to autobuild.
>>
>> Pushed.
>
>
Adding printf format decorations have thrown up more warnings. Here are two
additional patches that fix the new warnings.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patches
Type: application/octet-stream
Size: 2878 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160822/77ee7e5b/patches.obj>


More information about the samba-technical mailing list