[PATCH] smbd: Fix snapshot query on shares with DFS enabled

Volker Lendecke vl at samba.org
Fri Aug 19 05:31:56 UTC 2016

On Fri, Aug 19, 2016 at 12:46:23AM +0200, David Disseldorp wrote:
> > Alternatively, now we know in the pathname parser
> > that we're dealing with an @GMT- path (in SMB1)
> > or faked-up @GMT- path (in SMB2 via the TWrp token)
> > then we could remove the @GMT- entry from the path
> > inside the filename parser unix_convert(), and instead
> > of a flag in struct smb_filename we could add a time_t
> > entry which represents the 'previous version timestamp'
> > this path refers to.
> > 
> > That might be cleaner in the long run as there are
> > other areas in the smbd server code above the VFS
> > where we do pathname manipulation (parent_dirname()
> > etc.) which doesn't currently know about @GMT- pathnames.
> > 
> > Thoughts ?
> I'm very much in favour of your second approach here:
> - It should move a large amount of unnecessary complexity out of the
>   VFS modules.
> - The SMB2+ (timewarp) case would be streamline

This will give us more than one bad day with the shadow_copy2 module,
but when those are over, it will be a LOT cleaner, so go for time_t in


More information about the samba-technical mailing list