[PATCH] smbd: Fix snapshot query on shares with DFS enabled

Jeremy Allison jra at samba.org
Wed Aug 17 17:32:38 UTC 2016

On Wed, Aug 17, 2016 at 10:18:21AM -0700, Christof Schmitt wrote:
> If cli_set_previous_version(cli, time_t t) already registers the
> timestamp that should be used for opens, then the cli code could create
> the twrp context from that for SMB2, or in the SMB1 case insert the @GMT
> token in the path. That way the protocol differences between SMB1 and
> SMB2 would be hidden from the application using the cli.

It's the 'insert the @GMT token in the path' for SMB1 part that is
hard. It would touch a *LOT* of client code :-(.

> > > For the time being, I think we should apply your shadow_copy_data()
> > > patches and not my patch that puts the @GMT at the end. That would make
> > > "allinfo" properly list previous versions against all (reasonably
> > > recent) versions of samba in SMB2 mode, at the expense of providing a
> > > not-quite-realistic test for vfs_shadow_copy2.
> > 
> > I need to fix the source3/modules/vfs_snapper.c code first :-).
> > 
> > I'll send a patch to review soon !
> Should we push the fixes you have for shadowcopy2, or do you want to wait
> until everything is complete, including snapper and tests?

Already pushed the shadowcopy2 fixes with your reviewed-by.

I'm working on the snapper fix right now which I'll propose
for review today, and then the tests.

More information about the samba-technical mailing list