[PATCH] two small cleanups

Jeremy Allison jra at samba.org
Thu Aug 11 21:52:24 UTC 2016


On Thu, Aug 11, 2016 at 08:59:09PM +0200, Volker Lendecke wrote:
> On Thu, Aug 11, 2016 at 05:23:43PM +0200, Stefan Metzmacher wrote:
> > can you use system/threads.h instead of pthread.h ?
> 
> Attached.

LGTM. Pushed !

> From 3dd180f1930f2e0b10e8e94da906a6ca2e22dc89 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Sun, 31 Jul 2016 07:42:21 +0200
> Subject: [PATCH] lib: Use replace.h properly in pthreadpool
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/lib/pthreadpool/pthreadpool.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/source3/lib/pthreadpool/pthreadpool.c b/source3/lib/pthreadpool/pthreadpool.c
> index 4b745e4..917bafa 100644
> --- a/source3/lib/pthreadpool/pthreadpool.c
> +++ b/source3/lib/pthreadpool/pthreadpool.c
> @@ -17,21 +17,13 @@
>   * along with this program.  If not, see <http://www.gnu.org/licenses/>.
>   */
>  
> -#include "config.h"
> -#include <errno.h>
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <string.h>
> -#include <pthread.h>
> -#include <signal.h>
> -#include <assert.h>
> -#include <fcntl.h>
> +#include "replace.h"
>  #include "system/time.h"
>  #include "system/filesys.h"
> -#include "replace.h"
> -
>  #include "pthreadpool.h"
>  #include "lib/util/dlinklist.h"
> +#include "system/threads.h"
> +#include <assert.h>
>  
>  struct pthreadpool_job {
>  	int id;
> -- 
> 2.1.4
> 




More information about the samba-technical mailing list