[Patch] Fix the ";binary" suffix behavior

Jeremy Allison jra at samba.org
Tue Aug 9 15:46:50 UTC 2016


On Tue, Aug 09, 2016 at 06:08:04AM +0200, Volker Lendecke wrote:
> On Mon, Aug 08, 2016 at 05:13:59PM -0700, Jeremy Allison wrote:
> > On Mon, Aug 08, 2016 at 06:00:00PM +0200, Niklas Abel wrote:
> > 
> > > No problem, thanks for the review and the fast response.
> > 
> > OK - LGTM. Can I get a second Team reviewer ?
> 
> Attached find a set of cosmetic patches on top. Feel free to comment &
> squash.

Oh, some of these aren't just cosmetic, they're actually fixing some
bugs I missed. Thanks a *LOT* for that !

This is essential (IMHO). I'll squash and re-publish the set for
review.

> On the semantics -- RFC4522 describes what this is supposed to do. Can
> we really just ignore this?

Oh goodness. Didn't realize this is violating the RFC. Can
we get some comments from AD-experts here ?



More information about the samba-technical mailing list