[PATCH] Address some -O3 issues on Ubuntu 10.04

[Michael Adam]

On 2016-08-04 at 23:31 +0200, Stefan Metzmacher wrote:
> Hi Michael,
> 
> >> diff --git a/source4/dsdb/repl/drepl_out_helpers.c b/source4/dsdb/repl/drepl_out_helpers.c
> >> index bf8a372..29bb9d5 100644
> >> --- a/source4/dsdb/repl/drepl_out_helpers.c
> >> +++ b/source4/dsdb/repl/drepl_out_helpers.c
> >> @@ -446,6 +446,9 @@ static void dreplsrv_op_pull_source_get_changes_trigger(struct tevent_req *req)
> >>  		if (!W_ERROR_IS_OK(werr)) {
> >>  			DEBUG(0,(__location__ ": Failed to convert UDV for %s : %s\n",
> >>  				 ldb_dn_get_linearized(partition->dn), win_errstr(werr)));
> >> +			/* The above error can only be OUT_OF_MEMORY. */
> >> +			tevent_req_nterror(req, NT_STATUS_NO_MEMORY);
> >> +			return;
> > 
> > Why not use tevent_req_werror(req, werr) ?
> 
> We can't mix nterror and werror

Hm, that's kind of non-obvious. Thanks for the hint!
It's not documented either. ;-)
At least not near those functions.

If it is possible to combine them
but not allowed, that should be fixed..

> tevent_req_ntstatus(req, werror_to_ntstatus(werr));
> would work.

tevent_req_nterror(...), but OK.
I silently somewhat assumed that this was the
implementation of tevent_req_werror() ;-)

And Jeremy needs to update his autobuild.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160805/95999859/signature.sig>