[PATCH] Address some -O3 issues on Ubuntu 10.04

[Jeremy Allison]

On Thu, Aug 04, 2016 at 12:35:23PM -0700, Jeremy Allison wrote:
> On Thu, Aug 04, 2016 at 09:29:13PM +0200, Michael Adam wrote:
> > On 2016-08-04 at 08:56 -0700, Jeremy Allison wrote:
> > > On Thu, Aug 04, 2016 at 11:38:33AM +0200, Michael Adam wrote:
> > > > On 2016-08-04 at 00:39 +0200, Michael Adam wrote:
> > > > > On 2016-08-03 at 17:41 +0200, Stefan Metzmacher wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > here's an update that also includes andrew's backupkey test fixes.
> > > > > > 
> > > > > > All with bug references for the backports.
> > > > > > 
> > > > > > Please review and push.
> > > > > > 
> > > > > > (I already pushed the two patches from Andrew)
> > > > > 
> > > > > Reviewed-by: me and pushed to autobuild.
> > > > 
> > > > Re-pushed after failed autobuild.
> > > 
> > > Yes, mine and Andreas's autobuild failed also.
> > > I'll re-push one more time. Ralph seemed to
> > > get something through (god knows how :-).
> > 
> > Yeah... some time ago. ;-)
> > 
> > Metze's last autobuild failed as well.
> > 
> > Mine is currently running (at this moment at the drs tests...)
> > and it has metze's last autobuild content included.
> > Andreas' autobuild is in the queue mirroring mine.
> > 
> > > I think if metze recent work doesn't fix it the
> > > samba4.*samba_tool* tests need to be skipped
> > > until fixed.
> > 
> > This!
> 
> Well after metze's analysis I have one final attempt
> at fixing them (attached). I think patch #1 is a
> genuine bugfix that needs to go in regardless.
> 
> Patch #2 is a band-aid for the error, but something
> like it is needed to stop recursion (which currently
> isn't prevented in the repl code at all).
> 
> If you want to review and try pushing them I won't
> object :-).

Alternatively you could push the patch below instead...

Your choice :-).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-tests-Skip-samba4.blackbox.samba_tool.-and-samba4.patch
Type: text/x-diff
Size: 923 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160804/05b558d5/0001-s4-tests-Skip-samba4.blackbox.samba_tool.-and-samba4.diff>