External Sync VFS module

Jeremy Allison jra at samba.org
Thu Apr 28 00:04:15 UTC 2016

On Tue, Apr 26, 2016 at 04:51:51PM -0500, Alex Austin wrote:
> Hello,
> I've written a Samba VFS module to run an external file-sync program, and
> would appreciate feedback.

Currently you call the SMB_VFS_NEXT_XXX() function,
but then always call the sendsyncmsg() without
regard to whether the VFS call succeeded or failed.

Don't you need to check the return first, and only
call sendsyncmsg() on success ?


More information about the samba-technical mailing list