[PATCH - COVERITY] - dcesrv_backupkey_heimdal: Fix CID 1321647 - Unchecked return value

Robin Hack hack.robin at gmail.com
Tue Apr 26 14:54:35 UTC 2016


Hi Andreas. Thank you for review.

Version 2 of patch is attached.

On Tue, Apr 26, 2016 at 3:30 PM, Andreas Schneider <asn at samba.org> wrote:

> On Tuesday, 26 April 2016 15:22:19 CEST Robin Hack wrote:
> > Hello.
> >
> > Another small one.
> >
> > Have nice day
> > Robin Hack
>
> Hi Robin,
>
> a) please use DBG_ERR() instead of DEBUG(0, (..))
> b) You do not need to print the location, that's already done by the macro.
>
> --
> Andreas Schneider                   GPG-ID: CC014E3D
> Samba Team                             asn at samba.org
> www.samba.org
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dcesrv_backupkey_heimdal-Fix-CID-1321647-Unchecked-r.patch
Type: text/x-patch
Size: 1186 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160426/c60d20dc/0001-dcesrv_backupkey_heimdal-Fix-CID-1321647-Unchecked-r.bin>


More information about the samba-technical mailing list