Patch: eliminate duplicate definition of test_smbclient in the testprogs
slow at samba.org
Mon Apr 25 16:46:13 UTC 2016
On Mon, Apr 25, 2016 at 09:31:52AM -0700, Richard Sharpe wrote:
> On Mon, Apr 25, 2016 at 9:27 AM, Ralph Boehme <slow at samba.org> wrote:
> > On Mon, Apr 25, 2016 at 11:55:53AM +0200, Ralph Boehme wrote:
> >> On Sun, Apr 24, 2016 at 11:13:57AM -0700, Richard Sharpe wrote:
> >> > Hi folks,
> >> >
> >> > Attached is a patch that extracts the duplicated shell function
> >> > test_smbclient into an include file called common_test_fns.inc and
> >> > then makes those test progs that were defining it source that file and
> >> > use that definition.
> >> >
> >> > Comment, review, push if deemed appropriate ...
> >> lgtm, pushed!
> > this breaks samba4.blackbox.kinit_trust because it uses a different
> > UNC in the function.
> > One option would be to not keep the private function in
> > test_kinit_trusts_heimdal.sh, the other would be adding an UNC arg to
> > the function and change all callers to pass the needed UNC.
> OK, I see it now. I should have been more careful :-(
> I think the better option is to pass in the UNC as an argument.
> To fix this breakage can you workup the change and I can review it
> later today?
More information about the samba-technical