Patch: eliminate duplicate definition of test_smbclient in the testprogs

Ralph Boehme slow at
Mon Apr 25 16:27:11 UTC 2016

On Mon, Apr 25, 2016 at 11:55:53AM +0200, Ralph Boehme wrote:
> On Sun, Apr 24, 2016 at 11:13:57AM -0700, Richard Sharpe wrote:
> > Hi folks,
> > 
> > Attached is a patch that extracts the duplicated shell function
> > test_smbclient into an include file called and
> > then makes those test progs that were defining it source that file and
> > use that definition.
> > 
> > Comment, review, push if deemed appropriate ...
> lgtm, pushed!

this breaks samba4.blackbox.kinit_trust because it uses a different
UNC in the function.

One option would be to not keep the private function in, the other would be adding an UNC arg to
the function and change all callers to pass the needed UNC.


More information about the samba-technical mailing list