Patch: Refactor the dns_open_connection code to eliminate duplicate code and

Richard Sharpe realrichardsharpe at
Mon Apr 25 13:10:42 UTC 2016

On Sun, Apr 24, 2016 at 11:51 PM, Volker Lendecke
<Volker.Lendecke at> wrote:
> On Fri, Apr 22, 2016 at 06:53:43PM -0700, Richard Sharpe wrote:
>> Here is a patch that attempts to refactor the dns_open_connection code
>> to eliminate some duplicate code and fix EINTR handling in the UDP
>> path.
> Reviewed-by: Volker Lendecke <vl at>
> Before pushing: Why don't you go one step further and push the talloc
> handling of struct dns_connection to the helper too?

Ahhh, yes. I was too focused on the socket stuff, and noticed that the
TALLOC_FREEs could move there, but then thought it was ugly to have
the allocation in the caller and the frees in the helper. Now that you
point it out, both can move in and I can return the structure in a
pointer to a pointer.

I will send a new patch.

Richard Sharpe

More information about the samba-technical mailing list