Bug 11873 - samba 4.4.0 fails to compile on illumos/Solaris due to wrong getgrent_r configure check

Stefan Metzmacher metze at samba.org
Sat Apr 23 10:50:00 UTC 2016


Hi,

here's a patch for
https://bugzilla.samba.org/show_bug.cgi?id=11873

https://bugzilla.samba.org/show_bug.cgi?id=11816#c15
indicates that this will fix the build on illumos/Solaris
together with

commit 94f31295b12b20a68d596929ea428eb36f8c0d82
Author:     Jorge Schrauwen <sjorge at blackdot.be>
AuthorDate: Sun Apr 3 11:43:50 2016 +0200
Commit:     Jeremy Allison <jra at samba.org>
CommitDate: Wed Apr 6 00:15:17 2016 +0200

    configure: Don't check for inotify on illumos

    Bug: https://bugzilla.samba.org/show_bug.cgi?id=11816
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

Please review and push.

Thanks!
metze
-------------- next part --------------
From cb2c4b1318ef4ad11f9398dad7346634dc12b4e5 Mon Sep 17 00:00:00 2001
From: Jorge Schrauwen <sjorge at blackdot.be>
Date: Sat, 23 Apr 2016 12:45:06 +0200
Subject: [PATCH] nss_wrapper:wscript: fix configure check for getgrent_r

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11873
Signed-off-by: Stefan Metzmacher <metze at samba.org>
---
 lib/nss_wrapper/wscript | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/nss_wrapper/wscript b/lib/nss_wrapper/wscript
index 6c3d7f7..c727980 100644
--- a/lib/nss_wrapper/wscript
+++ b/lib/nss_wrapper/wscript
@@ -62,7 +62,7 @@ def configure(conf):
                                define='HAVE_SOLARIS_GETPWUID_R', headers='unistd.h pwd.h')
         conf.CHECK_C_PROTOTYPE('getgrent_r',
                                'struct group *getgrent_r(struct group *src, char *buf, int buflen)',
-                               define='SOLARIS_GETGRENT_R', headers='unistd.h grp.h')
+                               define='HAVE_SOLARIS_GETGRENT_R', headers='unistd.h grp.h')
         conf.CHECK_C_PROTOTYPE('getgrnam_r',
                                'int getgrnam_r(const char *name, struct group *grp, char *buf, int buflen, struct group **pgrp)',
                                define='HAVE_SOLARIS_GETGRNAM_R', headers='unistd.h grp.h')
-- 
1.9.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160423/47be3352/signature.sig>


More information about the samba-technical mailing list