There is a bunch of duplicated code in lib/addns/dnssock.c ...

Richard Sharpe realrichardsharpe at
Fri Apr 22 13:55:58 UTC 2016

On Fri, Apr 22, 2016 at 5:42 AM, Volker Lendecke
<Volker.Lendecke at> wrote:
> On Thu, Apr 21, 2016 at 06:56:50PM -0700, Richard Sharpe wrote:
>> Hi folks,
>> The duplicated code is in dns_tcp_open and dns_udp_open and it is
>> almost completely duplicated.
>> Here is a diff of the important parts of the code:
> Would it be possible to send this as git-format-patch? It looks
> correct, but git makes review a bit easier.

Let me work up a patch with a helper function first ...

Richard Sharpe

More information about the samba-technical mailing list