[PATCH] samba-tool throws error if there is an empty FSMO role

Andrew Bartlett abartlet at samba.org
Fri Apr 8 19:08:15 UTC 2016

On Fri, 2016-04-08 at 10:58 +0100, Rowland Penny wrote:

> I would also like to point out that I cannot seem to find any tests
> for 
> 'samba-tool fsmo'

Indeed.  All the more reason why we need that added. 

We have all been caught out with untested code.  I got embarrassed
recently when the 'samba-tool domain demote' code was shown to be
untested (in that case, it had a test, but that test got marked as
flapping, so was ignored).
Have a look at the tests in:
for some good examples.
Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list