[PATCH] samba-tool throws error if there is an empty FSMO role

[Andrew Bartlett]

On Tue, 2016-04-05 at 11:18 -0700, Jeremy Allison wrote:
> On Thu, Mar 31, 2016 at 01:23:43PM +0100, Rowland Penny wrote:
> > 
> > 
> > Hi, if there are any empty FSMO roles in AD, 'samba-tool fsmo'
> > throws an error, this happens if you try to show or transfer an
> > empty role.
> > 
> > The attached patch will cure this, if you run 'samba-tool fsmo
> > show'
> > any empty roles will be shown similar to this:
> > 
> >  DomainDnsZonesMasterRole owner: * The 'domaindns' role does not
> > have an FSMO roleowner
> > 
> > If you try to transfer an empty role, rather than throwing an
> > error,
> > it will now tell you the role as no owner i.e.
> > 
> > samba-tool fsmo transfer --role=pdc
> > * The 'pdc' role does not have an FSMO roleowner
> > 
> > You will then be able to seize the role.
> Ping. Can we get a second Team reviewer for Rowland for this ?
> 
> My python is too weak to do a good job here, so someone with
> more python experience would be appreciated.

A test on such a domain would be really nice.  I suspect the fl2000
environment in selftest won't have the DNS fsmo roles for example.

Otherwise it looks reasonable, but I'll look again when it has the
test.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba