[PATCH] file change time

Ralph Böhme slow at samba.org
Wed Sep 30 01:01:14 UTC 2015


On Tue, Sep 29, 2015 at 05:37:04PM -0700, Jeremy Allison wrote:
> On Sat, Sep 26, 2015 at 06:52:11PM -0700, Ralph Böhme wrote:
> > On Sat, Sep 26, 2015 at 12:32:09AM -0700, Ralph Böhme wrote:
> > > On Fri, Sep 25, 2015 at 10:46:23PM -0700, Jeremy Allison wrote:
> > > > On Fri, Sep 25, 2015 at 10:42:27PM -0700, Jeremy Allison wrote:
> > > > > On Fri, Sep 25, 2015 at 10:14:08PM -0700, Jeremy Allison wrote:
> > > > > > On Fri, Sep 25, 2015 at 07:12:22PM -0700, slow at samba.org wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > just came across this one. Looks like we don't handle ctime properly,
> > > > > > > patch with test attached.
> > > > > > > 
> > > > > > > The test passes with Windows but fails with Samba without the fix.
> > > > > > 
> > > > > > Looks completely correct to me ! Mod times can be tricky though,
> > > > > > so I hope it passes a full make test :-).
> > > > > 
> > > > > Hmmm. Doing a full make test with this I get:
> > > > > 
> > > > > [293(1167)/1872 at 22m14s] samba3.base.delaywrite(ad_dc)
> > > > > smbtorture 4.4.0pre1-DEVELOPERBUILD
> > > > > Using seed 1443246040
> > > > > 
> > > > > Running test_finfo_after_write
> > > > > UNEXPECTED(failure): samba3.base.delaywrite.finfo update on close(ad_dc)
> > > > > REASON: Exception: Exception: ../source4/torture/basic/delaywrite.c:1228: change_time changed
> > > > > 
> > > > > Now delaywrite is notoriously flaky, but this may show
> > > > > that the update on this field isn't as simple as it
> > > > > looks.
> > > > 
> > > > Can you try running test_finfo_after_write on a
> > > > Windows VM and seeing if this test is still a
> > > > valid one ?
> > > 
> > > will do.
> > 
> > what about this one? Added logic so ctime is set to mtime in
> > update_stat_ex_mtime() which is called when setting mtime in a stat_ex
> > to the value from a share mode lock. This one passes all delaywrite
> > tests.
> 
> Yeah, but it fails the new samba3.smb2.rename.rename_ctime
> test you added (I checked :-).
> 
> UNEXPECTED(failure): samba3.smb2.rename.rename_ctime(nt4_dc)
> REASON: Exception: Exception: ../source4/torture/smb2/rename.c:1503: Expression `ctime2 > ctime1' failed: rename didn't update ctime
> 
> Can you make sure whatever fix you come up with passes
> the old delaywrite tests and the new 's4:torture: smb2 rename ctime test'
> test ?

d'oh! Guess I should continue with this when I'm back from MS and got
enough sleep. Sorry!

-slow



More information about the samba-technical mailing list