[PATCH] file change time
jra at samba.org
Sat Sep 26 05:46:23 UTC 2015
On Fri, Sep 25, 2015 at 10:42:27PM -0700, Jeremy Allison wrote:
> On Fri, Sep 25, 2015 at 10:14:08PM -0700, Jeremy Allison wrote:
> > On Fri, Sep 25, 2015 at 07:12:22PM -0700, slow at samba.org wrote:
> > > Hi,
> > >
> > > just came across this one. Looks like we don't handle ctime properly,
> > > patch with test attached.
> > >
> > > The test passes with Windows but fails with Samba without the fix.
> > Looks completely correct to me ! Mod times can be tricky though,
> > so I hope it passes a full make test :-).
> Hmmm. Doing a full make test with this I get:
> [293(1167)/1872 at 22m14s] samba3.base.delaywrite(ad_dc)
> smbtorture 4.4.0pre1-DEVELOPERBUILD
> Using seed 1443246040
> Running test_finfo_after_write
> UNEXPECTED(failure): samba3.base.delaywrite.finfo update on close(ad_dc)
> REASON: Exception: Exception: ../source4/torture/basic/delaywrite.c:1228: change_time changed
> Now delaywrite is notoriously flaky, but this may show
> that the update on this field isn't as simple as it
Can you try running test_finfo_after_write on a
Windows VM and seeing if this test is still a
valid one ?
More information about the samba-technical