[PR PATCH] [Updated] CTDB: Use socket_wrapper only with selftest

[Amitay Isaacs]

On Fri, Sep 25, 2015 at 8:12 PM, Martin Schwenke <martin at meltin.net> wrote:

> Too complicated to work out while on vacation with only my phone. Amitay
> should be able to work it out...
>
> peace & happiness,
> martin
>
>
>
>
>
> On 25 September 2015 8:00:39 PM Andreas Schneider <asn at samba.org> wrote:
>
> On Friday 25 September 2015 11:10:42 Andreas Schneider wrote:
>>
>>> On Friday 25 September 2015 09:36:26 Martin Schwenke wrote:
>>> > On Thu, 24 Sep 2015 17:24:09 +0200, David Disseldorp <ddiss at suse.de>
>>> >
>>> > wrote:
>>> > > On Thu, 24 Sep 2015 17:13:37 +0200, Andreas Schneider wrote:
>>> > > > > A patch file from
>>> https://github.com/samba-team/samba/pull/14.patch
>>> > > > > is
>>> > > > > attached
>>> > > >
>>> > > > RB+
>>> > > >
>>> > > > Can I get a second team member review?
>>> > >
>>> > > Reviewed-by: David Disseldorp <ddiss at samba.org>
>>> >
>>> > I double-checked that this doesn't break the standalone CTDB build, so:
>>> >
>>> > Reviewed-by: Martin Schwenke <martin at meltin.net>
>>> >
>>> > The more the merrier...  :-)
>>>
>>> But autobuild doesn't work, because it doesn't run configure with
>>> --enable-
>>> selftest.
>>>
>>> The attached patch fixes the issue beforehand ...
>>>
>>
>> Hmm, ctdb doesn't have the option --enable-selftest. it doesn't include
>> selftest/wscript. How should we fix that? Martin?
>>
>>
I would modify the original patch with additional condition for standalone
build.

That way we don't need to support --enable-selftest option for CTDB
standalone build.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-build-Use-socket_wrapper-only-with-selftest.patch
Type: application/text
Size: 1219 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150925/fbd5a023/0001-ctdb-build-Use-socket_wrapper-only-with-selftest.bin>