The cd command in smbclient will not do pathname completion across a backslash (\)

Jeremy Allison jra at samba.org
Fri Sep 18 20:58:12 UTC 2015


On Fri, Sep 18, 2015 at 01:38:19PM -0700, Richard Sharpe wrote:
> Hi folks,
> 
> I noticed this annoying thing in the smbclient cd command.
> 
> It does completion, but will not complete across a backslash.
> 
> There are several problems here. The first is addressed by the following patch:
> 
> --- a/libcli/smbreadline/smbreadline.c
> +++ b/libcli/smbreadline/smbreadline.c
> @@ -136,6 +136,7 @@ char *smb_readline(const char *prompt, void (*callback)(void
> ),
>                 different versions of Readline, so the same function
>                 works in all of them to date, but we get compiler
>                 warnings in some.  */
> +               rl_basic_word_break_characters = " \t\n";
>                 rl_attempted_completion_function = RL_COMPLETION_CAST completion
> _fn;
>         }

C'mon Richard, submit as a git format-patch patch
with your 'Signed-off-by:' please :-).

That way it's an easy review + add without the reviewer
having to fart around fixing up stuff you can easily
do :-).



More information about the samba-technical mailing list