[PR PATCH] [Updated] Readme GitHub

Scott Lovenberg scott.lovenberg at gmail.com
Fri Sep 18 17:37:35 UTC 2015

On Fri, Sep 18, 2015 at 8:14 AM, Volker Lendecke
<Volker.Lendecke at sernet.de> wrote:
> Hi!
> As far as I can see, this still has long lines. Please fix
> that.
> Thanks,
> Volker

Hi Volker,
Did you look all the way to the end of the diff?  The longest in the
second patch is exactly 80 (plus 1 char for the '+' in the diff).

For some silly reason it looks like GitHub or the mailing list script
stacked the first revision diff on top of the second revision diff
instead of sending the second revision as a single diff.

Andrew, this could be problematic for larger patch sets that get
NACKed, revved and pushed to the feature branch that has the original
pull request still open. Perhaps we'll have to have a separate pull
request for each revision of a patch set?  Unfortunately that
fragments the discussion/history of a patch set, but I could see this
behavior to be much more confusing.

Peace and Blessings,

More information about the samba-technical mailing list