[PATCH] tevent and threads - infrastructure improvements - version #2

Stefan Metzmacher metze at samba.org
Tue Sep 15 07:10:47 UTC 2015

Hi Jeremy,

>> On Fri, Jul 24, 2015 at 10:16:15AM -0700, Jeremy Allison wrote:
>>> On Thu, Jul 23, 2015 at 04:50:37PM -0700, Jeremy Allison wrote:
>>>> FYI. I now have a working implementation of this
>>>> API - passes valgrind memcheck and drd !
>>>> Hurrah for me :-).
>>>> Will post an updated patch once I've finished
>>>> updating the tutorial.
>>> Here it is. Passes valgrind --tool=drd and
>>> valgrind --tool=memcheck.
>>> Metze please let me know if this is what
>>> you had in mind.
>>> Everyone else just review :-).
>> a few minor issue:
>> * always use talloc_get_type_abort() where possible
> Looks good to me. Do you want me to squash these
> into the main patch and add your signed-off-by ?
>> * reverse the order of signalling and unlocking in
>>   tevent_thread_proxy_schedule()
> LGTM. Again, squash and signed-off ?
> Also, are you getting to a 'Reviewed-by' ? :-).

I'll have a deeper look at this again next week at SDC.
As this introduces a new API which is written in stone then,
I'd like to check if the gensec gssapi would also able to use this
API before we publish it. So please don't push this yet even if
you have enough review tags, There're also some other changes
to libraries pending
It would be good to release all of them in a coordinated way.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150915/b45e9fe5/signature.sig>

More information about the samba-technical mailing list