[PATCHES] ctdb-scripts: Make NFS Linux kernel callout cache exportfs output

Amitay Isaacs amitay at gmail.com
Sun Sep 13 11:54:29 UTC 2015


Hi Martin,

On Fri, Sep 11, 2015 at 5:47 PM, Martin Schwenke <martin at meltin.net> wrote:

> The important patch is this one:
>
>   [PATCH 2/2] ctdb-scripts: Make NFS Linux kernel callout cache exportfs
>   output
>
>   exportfs can hang when, for example, DNS is flakey.  Given that it
>   doesn't change much, cache it.
>
>   Don't try to add error handling when exportfs fails but do print a
>   warning.  Proper error handling can be added separately.
>

I don't understand the need for nfs_export_file variable and the related
code.

For testing, CTDB_NFS_EXPORTS_FILE is set appropriately and exportfs stub
would consult the variable.  This would create the appropriate cache file.


> The first patch just gives NFS callouts somewhere to store state.
>

First patch is fine.


>
> Review and push appreciated...
>
> peace & happiness,
> martin
>

Amitay.


More information about the samba-technical mailing list