Patch: Fixed patch for moving RSVD/SHVXD to vfs_default

Jeremy Allison jra at
Fri Sep 11 16:12:22 UTC 2015

On Fri, Sep 11, 2015 at 08:12:43AM +0200, Michael Adam wrote:
> I fully disagree here!
> The point of this patch was, according to the commit message, to
>   "give VFS module writers a chance to handle RSVD opens
>    if they want to"
> This is not an urgent bugfix. It does not justify introducing
> new layer violations or aggravating those we already have in
> place. Instead, I think this completely reasonable motivation
> would have been a perfect case for discussing and doing the
> conecptually right changes without haste.
> I did not manage to come back to this topic earlier, so it has
> now landed this way. I will try to get the discussion going
> again now... ;-)

OK, so I disagree on this being a layering violation.

VFS modules need to get access to the create context
data, and they're already being passed to VFS_CREATE
(initially for vfs_fruit).

So I still don't get your objection here.

More information about the samba-technical mailing list