Is there a potential NULL-pointer de-reference in sourc3/modules/vfs_glusterfs.c?

[Richard Sharpe]

Hi folks,

In vfs_gluster_open (current master) we see:

        p_tmp = (glfs_fd_t **)VFS_ADD_FSP_EXTENSION(handle, fsp,
                                                          glfs_fd_t *, NULL);
        *p_tmp = glfd;


Shouldn't that last line be:

         if (p_tmp) *t_tmp = glfd

and maybe some other error checking?

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)