Is there a potential NULL-pointer de-reference in sourc3/modules/vfs_glusterfs.c?

Richard Sharpe realrichardsharpe at
Wed Sep 9 20:21:41 UTC 2015

Hi folks,

In vfs_gluster_open (current master) we see:

        p_tmp = (glfs_fd_t **)VFS_ADD_FSP_EXTENSION(handle, fsp,
                                                          glfs_fd_t *, NULL);
        *p_tmp = glfd;

Shouldn't that last line be:

         if (p_tmp) *t_tmp = glfd

and maybe some other error checking?

Richard Sharpe

More information about the samba-technical mailing list