Some coverity fixes
obnox at samba.org
Wed Sep 9 16:31:43 UTC 2015
On 2015-09-09 at 18:12 +0200, Michael Adam wrote:
> On 2015-09-09 at 17:40 +0200, Günther Deschner wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > Hi Anoop,
> > RB+ (as already reviewed off-list today).
> The patches look good.
> The patch to nss_wrapper needs to be done
> to the nss_wrapper repo. Usually we would pick up
> from nss_wrapper (and friends) by moving to a new
> 'upstream' version (unless it is very urgent).
> Nsswrapper repo is: git://git.samba.org/nss_wrapper.git
> I am going to push the other ones for a start.
One more thing:
The loadparm patch does not work.
If we apply it, we get a build break with
enum value not handled in switch.
So I guess we have to mark the CID invalid or something.
> Cheers - Michael
> > On 09/09/15 14:59, Anoop C S wrote:
> > > Hi all,
> > >
> > > Reviews are welcome.
> > >
> > > Thanks, --Anoop C S.
> > >
> > - --
> > Günther Deschner GPG-ID: 8EE11688
> > Red Hat gdeschner at redhat.com
> > Samba Team gd at samba.org
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v2
> > iEYEARECAAYFAlXwUukACgkQSOk3aI7hFogp4wCgmit1ExEYj36eXGwUarVIjh9L
> > voAAoJM6+MrYCYZtwmeM4oC6p2QNEj/s
> > =t0oP
> > -----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical