[PATCH] ctdb: honor CTDB_SOCKET in the server
obnox at samba.org
Tue Sep 8 10:15:20 UTC 2015
On 2015-09-08 at 20:13 +1000, Martin Schwenke wrote:
> On Tue, 8 Sep 2015 10:56:11 +0200, Michael Adam <obnox at samba.org> wrote:
> > I am not 100% sure this would be the intended behavior,
> > but it is more consistent to have the same precedence
> > chain in server and client:
> > - compiled-in default define CTDB_SOCKET
> > - overridden by env variable CTDB_SOCKET
> > - overridden by cmdline option --socket
> > Review appreciated!
> I don't think this can do any harm, but...
> In the ctdb client tool CTDB_SOCKET only really exists to support
> onnode, when CTDB_NODES_SOCKETS is set.
> If ctdbd_wrapper is used to start ctdbd then it will convert
> CTDB_SOCKET (either from configuration file or from environment) into
> --socket anyway.
> Tomorrow morning I'll push the other CTDB patches you posted... and
> this one if you really have a use for it. :-)
For me, this one was rather a matter of being systematic.
The situation with env vars, cmdline options and so on
confuses me slightly. ;-)
So I am fine with you omitting it - I also see your point.
Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical