[PATCHES] minor fix and formatting improvement

Michael Adam obnox at samba.org
Tue Sep 8 09:26:56 UTC 2015


This fixes the quotation marks of the deps list
of the param subsystem, and also introduces line breaks
in the list, while I'm at it. (I personally like that better
than the overly long lines. Diffs to these lists are also
more easy to read.)

Review/push appreciated.

Thanks - Michael
-------------- next part --------------
From aa62a48f1bade7f924ac6da6528929055a100115 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Fri, 3 Jul 2015 12:12:44 +0200
Subject: [PATCH 1/2] build: fix quotation of deps for 'param' subsystem.

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source3/wscript_build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/wscript_build b/source3/wscript_build
index f6351bf..49e18dd 100755
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -171,7 +171,7 @@ bld.SAMBA3_SUBSYSTEM('param',
                    lib/sharesec.c
                    lib/ldap_debug_handler.c
                    lib/util_names.c''',
-                   deps='samba-util PARAM_UTIL ldap lber LOADPARM_CTX samba3core smbconf param_local.h param_global.h cups''')
+                   deps='''samba-util PARAM_UTIL ldap lber LOADPARM_CTX samba3core smbconf param_local.h param_global.h cups''')
 
 # this includes only the low level parse code, not stuff
 # that requires knowledge of security contexts
-- 
2.4.3


From 6a72e34369b35def928e5e7b415b25173152ab3d Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Tue, 10 Jun 2014 16:48:40 +0200
Subject: [PATCH 2/2] build: line-break deps for 'param' subsystem

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source3/wscript_build | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/source3/wscript_build b/source3/wscript_build
index 49e18dd..48fb144 100755
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -171,7 +171,16 @@ bld.SAMBA3_SUBSYSTEM('param',
                    lib/sharesec.c
                    lib/ldap_debug_handler.c
                    lib/util_names.c''',
-                   deps='''samba-util PARAM_UTIL ldap lber LOADPARM_CTX samba3core smbconf param_local.h param_global.h cups''')
+                   deps='''samba-util
+                   PARAM_UTIL
+                   ldap
+                   lber
+                   LOADPARM_CTX
+                   samba3core
+                   smbconf
+                   param_local.h
+                   param_global.h
+                   cups''')
 
 # this includes only the low level parse code, not stuff
 # that requires knowledge of security contexts
-- 
2.4.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150908/ccb87e7c/attachment.sig>


More information about the samba-technical mailing list