[PATCH] add suport for SMB3_10 and SMB3_11 protocols in smbstatus

Stefan Metzmacher metze at samba.org
Wed Sep 2 06:51:20 UTC 2015

Hi Tom,

thanks for the suggestion!

> What exactly is "3_10"? There isn't such a dialect, the 3.1.1 version is the current and only 3.1.x. The previous SMB3's were 3.0 and 3.0.2.

That is 3.1.0 the dialect the preview versions of Windows 10 were using.

> I would strongly suggest using the canonical numbering conventions for reporting these. 2.0.2, 2.1, 3.0, 3.0.2 and 3.1.1.

If we do this we use use 2.0.2, 2.1.0, 3.0.0, 3.0.2 and 3.1.1, skipping
a trailing '0', is still confusion.

We can think about this for future versions of samba, but for now we
should be consistent
with the values used in smb.conf. And there we currently have:

static const struct enum_list enum_protocol[] = {
        {PROTOCOL_DEFAULT, "default"}, /* the caller decides what this
means */
        {PROTOCOL_SMB2_10, "SMB2"}, /* for now keep PROTOCOL_SMB2_10 */
        {PROTOCOL_SMB3_11, "SMB3"}, /* for now keep PROTOCOL_SMB3_11 */
        {PROTOCOL_SMB3_11, "SMB3_11"},
        {PROTOCOL_SMB3_10, "SMB3_10"},
        {PROTOCOL_SMB3_02, "SMB3_02"},
        {PROTOCOL_SMB3_00, "SMB3_00"},
        {PROTOCOL_SMB2_24, "SMB2_24"},
        {PROTOCOL_SMB2_22, "SMB2_22"},
        {PROTOCOL_SMB2_10, "SMB2_10"},
        {PROTOCOL_SMB2_02, "SMB2_02"},
        {PROTOCOL_NT1, "NT1"},
        {PROTOCOL_CORE, "CORE"},
        {-1, NULL}

At least we need to support the current names as fallback in order
to avoid breaking existing configurations.

We can also think about removing all the preview dialects
( SMB 2.2.2, 2.2.4 and 3.1.0).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150902/080324fd/signature.sig>

More information about the samba-technical mailing list