winbindd crash

Stefan Metzmacher metze at samba.org
Fri Oct 30 16:44:07 UTC 2015


Hi Noel,

>>> Regarding the crash prevention I think we should do that in caller.
>>> rpccli_netlogon_network_logon/rpccli_netlogon_password_logon or even
>>> their callers
>>> should check. They should never pass creds=NULL.
>> I opened a bug https://bugzilla.samba.org/show_bug.cgi?id=11569 and
>> attached a patch with your suggestions there
>>
>> thanks,
>> Noel
> 
> Is the version attached to the bug ok, is there something more needed ?
> 
> Noel
> 

Can you split this into two commits?

+		if (!domain->conn.netlogon_creds) {
+			DEBUG(3, ("No security credentials available.\n"));
+			result = NT_STATUS_CANT_ACCESS_DOMAIN_INFO;

Can you please use if (domain->conn.netlogon_creds == NULL) ?
and more details into the debug message (at least the domain name).

Also please at the BUG: https://bugzilla... to the commit messages.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151030/289b7f9e/signature-0001.sig>


More information about the samba-technical mailing list