[PATCH] Fix / slightly simplify smbd/scavenger

Ralph Boehme rb at sernet.de
Fri Oct 30 06:46:39 UTC 2015


On Thu, Oct 29, 2015 at 03:26:53PM -0700, Jeremy Allison wrote:
> On Thu, Oct 29, 2015 at 08:23:26PM +0200, Uri Simchoni wrote:
> > 
> > 
> > On 10/29/2015 06:02 PM, Volker Lendecke wrote:
> > >+	ret = read_data(fd, child, sizeof(child));
> > >+	if (ret == -1) {
> > Doesn't seem to take EOF into account, but neither does the original
> > code. How come?
> 
> fd's are created by socketpair() and not set non-blocking,
> so shouldn't get a zero return.

But wouldn't one side get 0 when the other does a close?

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list