[PATCH] Fix / slightly simplify smbd/scavenger

Jeremy Allison jra at samba.org
Thu Oct 29 22:26:53 UTC 2015


On Thu, Oct 29, 2015 at 08:23:26PM +0200, Uri Simchoni wrote:
> 
> 
> On 10/29/2015 06:02 PM, Volker Lendecke wrote:
> >+	ret = read_data(fd, child, sizeof(child));
> >+	if (ret == -1) {
> Doesn't seem to take EOF into account, but neither does the original
> code. How come?

fd's are created by socketpair() and not set non-blocking,
so shouldn't get a zero return. Probably good to add that
check though.



More information about the samba-technical mailing list