[PR PATCH] [Updated] build:wafsamba: Removed hard-coded class names in build scripts

Michael Adam obnox at samba.org
Wed Oct 28 20:40:00 UTC 2015


pushed with andrew's and david's review as per github

On 2015-10-28 at 20:07 +0000, github at samba.org wrote:
> There is an updated pull request by ita1024 against master on the Samba Samba Github repository
> 
> https://github.com/ita1024/samba class_instances
> https://github.com/samba-team/samba/pull/28
> 
> build:wafsamba: Removed hard-coded class names in build scripts
> Using hard-coded class names prevents subclassing and make it hard
> to reason about the workflow. The wscript files read during the build
> must be read during the installation phase as well.
> 
> Signed-off-by: Thomas Nagy <tnagy at waf.io>
> Reviewed-by: <your name here>
> Reviewed-by: <your name here>
> 
> A patch file from https://github.com/samba-team/samba/pull/28.patch is attached


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151028/fd9a0bba/signature.sig>


More information about the samba-technical mailing list