[PATCHES] Avoid system krb5.conf in selftest

Uri Simchoni uri at samba.org
Tue Oct 27 07:30:54 UTC 2015



On 10/27/2015 09:25 AM, Andreas Schneider wrote:
> On Monday 26 October 2015 23:17:53 Uri Simchoni wrote:
>> Hi,
>>
>> Following patches fix "make test" on my FC22 box. The recurring theme
>> was that this box has a krb5.conf that is deemed invalid by the Heimdal
>> libs embedded in samba. Tests that need krb5.conf take care to divert
>> the test program from the system krb5.conf to the testenv version. Tests
>> that do not need krb5.conf sometimes omit this, causing the test to read
>> the system krb5.conf (while creating a context) and choke.
>>
>> I haven't checked whether it's an MIT thing or an invalid config - IMHO
>> it doesn't matter - a test should read the system krb5.conf at all.
>>
>> The patches don't necessarily eliminate ALL references to the system
>> krb5.conf, just the ones that fail tests.
>>
>> Review and push appreciated.
>>
>> Thanks,
>> Uri.
> Great catch, could you please backport to 4.2 and 4.3 too?
>
>
> 	-- andreas
>
Umm... OK. I didn't open a bug in the first place b/c I figured it's not 
a bug in the end-product, just in the self-test environment, but I can 
see I was wrong about this (the "product" of an OSS project is the code 
base, actual deployed systems are derived from this code base, and from 
a practical point of view - people want to run make test and succeed in 
stable versions too)

Thanks,
Uri



More information about the samba-technical mailing list