[PATCH] Replace CHECK_STATUS with torture macros

[Anoop C S]

On Mon, 2015-10-26 at 11:26 +0100, Michael Adam wrote:
> Hi Anoop,
> 
> The patch looks clean now.
> But I have one more request:
> 
> Just as you split the addition of torture_asserts for
> the smb2_unlink calls (that had no assert with them
> before) into a patch of their own, could you do the
> same with the smb2_util_close calls?
> I just would like the patch that is called
> "Replace CHECK_STATUS with torture_assert macros"
> to do that and not more (adding checks where there
> were none before). You could do a third patch or
> add add these hunks to the patch with the unlink part.
> It is up to you.
> 

Attaching 3 patches as per Michael's comments.

> Thanks - Michael
> 
> 
> On 2015-10-22 at 13:44 +0530, Anoop C S wrote:
> > On Wed, 2015-10-21 at 14:14 -0700, Jeremy Allison wrote:
> > > On Wed, Oct 21, 2015 at 12:38:48PM +0530, Anoop C S wrote:
> > > > Hi all,
> > > > 
> > > > Attached are some clean-up patches for replacing CHECK_STATUS
> > > > with
> > > > corresponding torture macros and adds some torture_assert for
> > > > unlink
> > > > calls under smb2/session.c. Reviews are mostly welcome.
> > > > 
> > > > Thanks and Regards,
> > > 
> > > Can you clean this up a bit ? Some whitespace errors
> > > and things like this:
> > > 
> > > > -     smb2_util_unlink(tree1, fname);
> > > > +        smb2_util_unlink(tree1, fname);
> > > 
> > > that really aren't a change at all (and will disappear
> > > once you've fixed up the whitespace problems).
> > > 
> > 
> > Corrected whitespace errors shown via checkpatch.pl and attached
> > new
> > patch set.
> > 
> > --Anoop C S.
> > 
> > > Thanks,
> > > 
> > > Jeremy.
> > > 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4.torture.smb2-session-Replace-CHECK_STATUS-with-to.patch
Type: text/x-patch
Size: 25939 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151027/c0a67fa5/0001-s4.torture.smb2-session-Replace-CHECK_STATUS-with-to-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4.torture.smb2-session-Add-torture-assert-for-unlin.patch
Type: text/x-patch
Size: 5320 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151027/c0a67fa5/0002-s4.torture.smb2-session-Add-torture-assert-for-unlin-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4.torture.smb2-session-Add-torture-assert-for-close.patch
Type: text/x-patch
Size: 1730 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151027/c0a67fa5/0003-s4.torture.smb2-session-Add-torture-assert-for-close-0001.bin>