[PATCH] build: --picky-developer implies --enable-developer

[Uri Simchoni]

On 10/26/2015 11:27 AM, Martin Schwenke wrote:
> I first met this back in March when I used --picky-developer on
> its own and managed to push something that wouldn't pass autobuild.  I
> never forget (or my inbox never does)... so how about the following?  :-)
>
>    Have --picky-developer do the --enable-developer setup too, instead of
>    requiring both options to be specified.  This makes it obey the
>    principle of least surprise.
>
> This seems to work fine without the extra "if not Options.options.developer:"
> but I think having it there makes things clearer...
>
> Review and push appreciated...
>
> peace & happiness,
> martin
>       if Options.options.picky_developer:
> +        if not Options.options.developer:
> +            setup_developer(conf)
Seems like this is not 100% equivalent to --enable-developer 
--picky-developer, because there are other places in some wscripts that 
Options.options.developer is checked. It would be safer to set 
Options.options.developer if picky_developer is set, but we have to do 
it early enough, and without modifying the core waf code.

If we can't find a place that's provably early enough, then maybe we can 
have a function which checks either flag, and then replace all 
references to options.developer with this function.

Thanks,
Uri.