[PR PATCH] [Updated] build:wafsamba: dead code removal in gettext detection

Uri Simchoni uri at samba.org
Sun Oct 25 18:11:26 UTC 2015



On 10/25/2015 02:33 PM, github at samba.org wrote:
> There is an updated pull request by ita1024 against master on the Samba Samba Github repository
>
> https://github.com/ita1024/samba cflags_noeffect
> https://github.com/samba-team/samba/pull/27
>
> build:wafsamba: dead code removal in gettext detection
> The values conf.env.CFLAGS and conf.env.LDFLAGS have no effect in waf 1.5
> Additionally, values must be appended using:
> conf.env.append_value('CCFLAGS', value)
> Keep in mind that conf.env.CCFLAGS returns an empty list when not undefined,
> which means that extending that list will have no effect at all.
>
> Signed-off-by: Thomas Nagy <tnagy at waf.io>
> Reviewed-by: <your name here>
> Reviewed-by: <your name here>
>
> A patch file from https://github.com/samba-team/samba/pull/27.patch is attached
Reviewed-by: Uri Simchoni <uri at samba.org>



More information about the samba-technical mailing list