Comments on GitHub PRs
Uri Simchoni
uri at samba.org
Sun Oct 25 10:18:14 UTC 2015
On 10/25/2015 07:23 AM, Uri Simchoni wrote:
> Hi Andrew,
>
> I tried commenting on a PR in github, figuring that it's easier to do
> than posting on the list and may serve the contributor better, but it
> didn't generate an email to the list which breaks the "discussions
> continue on the list" rule.
>
> The gh-mailinglist.py server seems to handle comments, don't know
> whether GitHub is configured to send them and what's the intent.
>
> Can you clarify?
>
> The PR in question is https://github.com/samba-team/samba/pull/27
>
> Thanks,
> Uri.
Well general comments obviously work, I was referring to commenting on
the diff - that's very convenient, instead of downloading the patch and
copy-pasting the relevant line to a reply message. It was this kind of
comment that I generated which didn't generate an email.
Thanks,
Uri
More information about the samba-technical
mailing list