Arggghhh. Missing 'Signed-off-by:' and 'Reviewed-by:' in revert I pushed...

Jeremy Allison jra at samba.org
Fri Oct 23 18:22:02 UTC 2015


On Thu, Oct 22, 2015 at 03:24:29PM +1100, Martin Schwenke wrote:
> [Sorry to those getting this twice.  The old message I replied to
>  didn't have the modern lists.samba.org address for samba-technical.]
> 
> On Tue, 15 Jul 2014 14:50:40 -0700, Jeremy Allison <jra at samba.org>
> wrote:
> 
> > On Wed, Jul 16, 2014 at 07:37:05AM +1000, Martin Schwenke wrote:
> > > On Tue, 15 Jul 2014 09:26:35 -0700, Jeremy Allison <jra at samba.org>
> > > wrote:
> > >   
> > > > On Tue, Jul 15, 2014 at 10:01:50AM +0200, Kai Blin wrote:  
> >  [...]  
> > > > 
> > > > That's a really good idea - thanks !  
> > > 
> > > If you do this, can you please update the autobuild documentation to
> > > show how this is done?  
> > 
> > I think it requires git 1.8.2 or above.
> > 
> > Here's a sample pre-push hook script:
> > 
> > https://github.com/git/git/blob/87c86dd14abe8db7d00b0df5661ef8cf147a72a3/templates/hooks--pre-push.sample
> > 
> > I'm planning to work from that.
> 
> I saw someone else revert something missing a "Reviewed-by:" recently,
> so I decided to have a go at this.  I'll paste it here first to see if
> anyone has any comments:

That looks really nice ! I'll give this a go also..



More information about the samba-technical mailing list