winbindd crash

[Noel Power]

Hi Metz,

On 22/10/15 12:03, Stefan Metzmacher wrote:
[...]
> I think what we really need is a way to return to the parent and have
> the fallback logic there, the parent should then re-route to the
> correct domain child by clearing WBFLAG_PAM_CONTACT_TRUSTDOM before
> calling find_auth_domain(). 
would it be appropriate to use the NT_STATUS_CANT_ACCESS_DOMAIN_INFO
status returned to the parent and then try the previous logic to attempt
to find the proper domain to route to ?
> Regarding the crash prevention I think we should do that in caller.
> rpccli_netlogon_network_logon/rpccli_netlogon_password_logon or even
> their callers should check. They should never pass creds=NULL.

how about the attached ?

thanks,
Noel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Prevent-null-ptr-access-by-returning-error-if-no-cre.patch
Type: text/x-patch
Size: 1817 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151022/411d3e91/0001-Prevent-null-ptr-access-by-returning-error-if-no-cre.bin>