[PR PATCH] [Updated] repl_meta_data fixes

[Andrew Bartlett]

On Wed, 2015-10-21 at 16:40 +0200, Stefan Metzmacher wrote:
> Am 21.10.2015 um 00:50 schrieb github at samba.org:
> > There is an updated pull request by abartlet against master on the
> > Samba Samba Github repository
> > 
> > https://github.com/abartlet/samba repl_meta_data-fixes
> > https://github.com/samba-team/samba/pull/26
> > 
> > repl_meta_data fixes
> > While developing the demote-dc branch adding better support for
> > 'samba-tool domain demote --remove-other-dead-server' command I
> > tested against a clone of a Windows 2012R2 server.  Removing an
> > RODC triggered a failure due to the binary linked attribute msDS-
> > RevealedUsers
> 
> Regarding the first patch, what's the interaction of
> ldb_asprintf_errstring() and ldb_module_oom(module)?
> This is quite confusing that we have ldb_module_oom(module) in some
> places
> and remove it in others.

Thanks for spotting that.  It should be removed in all cases, it
overwrites the same variable.

> Regarding the 2nd patch, is this the fix for
> https://bugzilla.samba.org/show_bug.cgi?id=11139 ?
> If so please add the bug url to the commit message

Yes.  Do you have a sane way to reproduce this?  (My reproduction steps
involved demoting a clone of a Windows DC)

> Why "if (sa->linkID != 0 && (sa->linkID & 1)) {"
> can't this be simply "if (sa->linkID & 1) {" ?

Yes, it can be. 

Thanks for taking a look!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151022/04983b76/signature.sig>